Giters

skybluesofa / onthisday

Get fun events and holidays for a given day.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Clean up the data parser

skybluesofa opened this issue · comments

commented

src/Data/Parser.php contains a bunch of duplicated code. This duplicated functionality should be encapsulated into private utility methods.

Specifically, the duplicated functionality:

  • getRecurringConfigurationBasedEvents() and getRecurringConfigurationBasedHolidays()
  • getSpecificDateBasedEvents() and getSpecificDateBasedHolidays()
  • getRecurringDateBasedEvents() and getRecurringDateBasedHolidays()
commented

I've updated this and added tests