skpm / fs

Drop-in replacement for the fs NodeJS package

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

readdirSync doesn't working

nadavkaner opened this issue · comments

When using readdirSync function with encoding 'buffer' as the options argument, the error occur in this line: https://github.com/skpm/fs/blob/master/index.js#L239

what's the error?

I guess the problem is that pathName value type is a string but Buffer.from expect to get another type

image

Ah so it's a bug in @skpm/buffer. I'll fix it and it will be shipped in Sketch 58.

Just by curiosity, why would you want the path names as buffers?

It's funny because i got to this by accident because I thought it will return me the files content of the directory, but i understand that the implementation is to return the path names and not the content so it's not fit to my needs..

Ah yep indeed, I always found this option funny for that specific method haha