How to use createSelectorCreator with reselect-tools
samuelcastro opened this issue · comments
I'm creating a custom selector with my own deep equality check like:
const createDeepEqualSelector = createSelectorCreator(defaultMemoize, equals);
However, it's not clear how to use with with reselect-tools.
Hey @samuelcastro - this was a pretty obvious feature but I left it out because I haven't been using it in my codebase. The problem is here. This should default to createSelector and be overridable. For now you can probably just copy it. Don't worry about _allSelectors not being exposed - you can get your selectors into the graph by registering them.
ok thanks @skortchmark9 I think I will create a fork and implement it, or maybe a PR.
In version 4.0.0 of reselect, they'll be adding selector dependencies internally, which will mean we no longer need to shim createSelector. If the shim isn't necessary, we won't have this problem any more.
What is the status of this? I would like to use it but I need createSelectorCreator functionality?
Fixed in #13