[Internal] Kill check_constraint_consistency in skipTypingUtils
tnowacki opened this issue · comments
Todd Nowacki commented
When adding constraints we do some wonky joining of constraints so they are consistent with all tvars.
This is so all type variables have the same physical constraint when entering the NBE. (Physical constraints does not include any KTraits)
Ideally, when constraints are solved, solve each constraint individually with separate accs. After solving all of them, join the physical values contravariantly. This should provide physical values for all tvars that overlap without having to do this constraint forwarding.