skinny-http-client can not parse `Set-Cookie` what contains path atribute

[Manabu Nakamura]

skinny-framework/http-client/src/main/scala/skinny/http/HTTP.scala

Lines 194 to 195 in 99b1072

 setCookie.split("=") match { 
   case Array(name, _) => Some(name -> setCookie) 

            setCookie.split("=") match {
              case Array(name, _) => Some(name -> setCookie)

When setCookie contains path like as Set-Cookie: foo=bar; path=/; HttpOnly,
setCookie.split("=") returns an array that has 3 elements. Array("foo", "bar; path", "/; HttpOnly")

Should it split("=", 2) ?

[Kazuhiro Sera]

Thank you. If you have time, please fix this 🙇
I will be able to immediately do the next patch release.

[kenji yoshida]

FYI

• https://github.com/AsyncHttpClient/async-http-client/blob/async-http-client-1.9.36/src/main/java/com/ning/http/client/cookie/CookieDecoder.java#L26-L144
• https://github.com/scalaj/scalaj-http/blob/2.2.1/src/main/scala/scalaj/http/Http.scala#L194-L195

[Kazuhiro Sera]

Thank you. The code just failed to extract cookie names and return the header value as-is. Just fixing it as @gakuzzzz suggested should be enough in this case.