sjoerdk / dicomtrolley

Retrieve medical images via WADO, MINT, RAD69 and DICOM-QR

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Unify Query object for across Searcher classes

sjoerdk opened this issue · comments

  • dicomtrolley version: 1.1.1

Description

There is no base type for a DICOM query in dicomtrolley.

The query parameter in trolley.find_studies does not have a type.

https://github.com/sjoerdk/dicomtrolley/blob/master/dicomtrolley/mint.py#L125 is a base object, not implementing any underlying query type.

The consequence of this is that you cannot switch between backends in trolley without re-writing all queries. This should change. There are particular parameters that are unique to certain methods, like MintQuery having a limit parameter. But this is only for advanced usage. There is a large set of parameters that are universal. Make sure it is possible to use this universal set without caring about the backend