webroot parametr
stenlyk opened this issue · comments
Hi I just try your script and ends on this line
https://github.com/sjau/le2ispc/blob/master/le2ispc#L185
Should be there webroot of domain like (/var/www/domain.ltd/web) not just /var/www?
Or where is the magic?
/var/www is fine since you make an alias on apache on lines 109-115, 120-127
not really sure how nginx works.
Ok nginx have alias to but for some security reason I'm not able to make this wokk on /var/www/ but it works on /usr/share/ do you want pull request with this change?
How would that be a security reason?
Anyway, I made webroot now configurable for apache. Feel free to provide a pull request to do the same for nginx.
I can make a pull but I just made the following change around line 358:
echo "- Run Let's Encrypt Tool\n";
#$webroot = "/var/www/";
$webroot = "/var/www/$domain/web";
This way you don't need the alias, it will write the stuff into the domain being setup .well-known folder and "just work". At least it's worked for 2 domains I've setup so far.
Also this was for apache but the alias didn't work for me because of the # of domains on my ispconfig system.
well, that works also. However the beauty of the alias is that there aren't suddenly new folder for the end user. I think this can be closed.