Little typo in windows build
opened this issue · comments
in console_size.h :
line 16 : #elif defined(TQDM_ON_WINDOWS) [not define]
line 17 : add #define NOMINMAX before #include <windows.h> [avoid std min/max conflict]
build and test fine on windows after that change. good job and thank you very much.
Hi, thanks for finding that!
Typo fixed in e4e2e6a
I think NOMINMAX definition should go to CMakeLIsts.txt not to the headers. To do that I need to write a bit of CMake boilerplate to turn the repo into CMake-friendly library. I'll try to that a bit later.
On second thought in-source NOMINMAX fix sounds fine. I applied patch as you suggested.