sivaprakashDesingu / react-voice-recorder

This (react-voice-recorder) is a JavaScript library for React Applicaiton which will be used to record voice as audio and download the same.

Home Page:https://codesandbox.io/s/react-voice-recorder-mydov?file=/src/App.js

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Red Dot in favicon persist even after recording stopped

rohitmyaim opened this issue · comments

The stopRecording function has to properly handle stop track recording as given in below url

https://pretagteam.com/question/remove-red-icon-after-recording-has-stopped

image

image

I tried creating a PR but Access denied to push so please fix this.

Thanks for creating such a good module

MediaRecorder can't access to getAudioTracks method. It should be MediaStream. I have created pull request to fix. pull-33

@ozdemiremrah Thanks for the PR, Will check your PR and merge your code.

@ozdemiremrah After merged your code getting the below issue. Please fix and Create PR again,
For now, we are about to revert your change. Once you fixed that issue, will merge the code again.
Also has some documentation on README file.
download
n.

@ozdemiremrah After merged your code getting the below issue. Please fix and Create PR again, For now, we are about to revert your change. Once you fixed that issue, will merge the code again. Also has some documentation on README file. download n.

it's new feature, you must pass handleCountDown parameter to compontent.
for example;
<Recorder ...otherprops handleCountDown={(d)=> console.log(d)}>

@ozdemiremrah Update the documentation with the brief into, So use will come to know the purpose of new feature.
We should give to the user with clear guideline when they come here and go through.

@sivaprakashDesingu Readme updated and handleCountDown added to default props. pull-34 Thank you for information.

@ozdemiremrah Thanks for the update.

@rohitmyaim we resolved your issue.