site-prism / site_prism

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

New Work: Rubocop RSpec Fixes

luke-hill opened this issue · comments

The first of a series of Issues I'm creating for outstanding "small" tasks that people can contribute to if they want to get involved with site_prism as an Open Source Project.

Problem to fix

We have a series of rubocop overrides in rubocop_todo.yml

Ideal behaviour

These need removing, and manually fixing up in the spec files.
You can fix up "some" of these, or all of these. Whatever you find easiest. There is a reasonable amount of work to fix up.

Steps to validate work is correct

bundle exec rake should still pass fully green.

Partially fixed by #32

@ineverov Here we should document if we are wanting to extend the rspec maxtests rule.

Now fixed in master