Bug in borer-derivation? deriveCodec fails to compile when using type alias

Question

Bug in borer-derivation? deriveCodec fails to compile when using type alias

MarconZet opened this issue 3 years ago · comments

type Foo = String
case class Bar(bar: Foo)
implicit val barCodec: Codec[Bar] = deriveCodec

fails build with:

[error] MyBorerAkkaSerializer.scala:54:39: value writeMyBorerAkkaSerializer.this.Foo is not a member of io.bullet.borer.Writer
[error]   implicit val barCodec: Codec[Bar] = deriveCodec

Expected behaviour: Build successful

I found a workaround with:

implicit val barCodec: Codec[Bar] = Codec(
  Encoder.from(Bar.unapply _),
  Decoder.from(Bar.apply _)
)

but that's far from an elegant solution.

Mathias · Answer 1 · Tue Apr 27 2021 20:21:13 GMT+0800 (China Standard Time)

Ok, thank you for reporting.
I happen to have time right now to look at this and will do so right away...

Mathias · Answer 2 · Tue Apr 27 2021 20:43:02 GMT+0800 (China Standard Time)

Thank you, @MarconZet, for reporting.
The fix is already in the master branch.
Would you like a quick patch release to unblock this issue on your side?

Paweł Lipski · Answer 3 · Tue Apr 27 2021 20:46:45 GMT+0800 (China Standard Time)

We'd appreciate a patch release :)

Mathias · Answer 4 · Tue Apr 27 2021 20:53:49 GMT+0800 (China Standard Time)

Ok, just pushed borer 1.7.1 to sonatype.
You can pull it from there or wait for the sync to maven central, which is probably going to take a few hours though...
Thanks again for reporting!

Paweł Lipski · Answer 5 · Wed Apr 28 2021 01:22:58 GMT+0800 (China Standard Time)

Wow that's one of the fastest report-to-release cycles I've seen in OSS so far ❤️

Mathias · Answer 6 · Wed Apr 28 2021 01:46:19 GMT+0800 (China Standard Time)

:)
It was just a lucky coincidence that the bug report hit a perfect break between things on my side.
I'm glad that borer works out for your setup!

Paweł Lipski · Answer 7 · Wed Apr 28 2021 02:56:27 GMT+0800 (China Standard Time)

Actually, FYI, as you've probably noticed, we're working on ready-to-use serializer for Akka messages/event/states, since Jackson that's suggested by Akka docs is a joke (surprising runtime failures, no support for Scala objects/ADTs etc.) 😅

Are you aware of any work that has been already done in that direction? There's borer-akka-compat but AFAICS it doesn't provide a ready Serializer, just Codecs for ActorRefs etc.

Paweł Lipski · Answer 8 · Wed Apr 28 2021 03:18:38 GMT+0800 (China Standard Time)

Also @sirthias ... would it be possible to retain support for Scala 2.12 in 1.7+? Since AFAICS 1.7.0 and 1.7.1 have only been published for 2.13 ://

Mathias · Answer 9 · Wed Apr 28 2021 22:44:05 GMT+0800 (China Standard Time)

There's borer-akka-compat but AFAICS it doesn't provide a ready Serializer, just Codecs for ActorRefs etc.

Yes. The reason is that we haven't needed these things ourselves yet.
I'd be happy to review and merge any PRs if you want to submit any...

Paweł Lipski · Answer 10 · Wed Apr 28 2021 22:51:08 GMT+0800 (China Standard Time)

Great! We're prototyping that as a separate project for convenience as for now, but it makes sense to integrate it back into main borer repo... opened VirtusLab/akka-serialization-helper#18 for that

mushtaq · Answer 11 · Sun May 09 2021 12:14:00 GMT+0800 (China Standard Time)

@PawelLipski We are using borer for akka-serialization using the pattern mentioned here.

Paweł Lipski · Answer 12 · Mon May 10 2021 19:09:45 GMT+0800 (China Standard Time)

@mushtaq actually! since you're using Borer for a bit longer than us... do you have any experiences with migrating Akka events when Borer is used as a serializer (or any other library, for that matter)?

mushtaq · Answer 13 · Tue May 11 2021 19:56:10 GMT+0800 (China Standard Time)

Unfortunately, no. So far, we do not have to deal persisting these events.

I just came across transducers in latest version of borer. Will that help?

Paweł Lipski · Answer 14 · Tue May 11 2021 20:33:10 GMT+0800 (China Standard Time)

Looks promising! Let us take a look 👁️