sir-dunxalot / ember-tooltips

Easy and extendible tooltips for Ember components - http://sir-dunxalot.github.io/ember-tooltips/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ember-tooltips 3.3.1+ build breaks w/ lazy engines

thec0keman opened this issue · comments

Upgrading our application from 3.3.0 -> 3.3.2, and we're getting build failures:

  - broccoliBuilderErrorStack: Error: ENOENT: no such file or directory, lstat '/var/folders/89/kt8fhhgx0pz0m3s5s588tkvc0000gn/T/broccoli-42794yLQNVhp1CiNT/out-016-broccoli_merge_trees_empty_merge_tree/vendor/ember-tooltips--popper.js'

Unfortunately I do not have time to dig into this more right now, but we do have an app with several lazy-load engines, and at least one does include ember-tooltips, so I suspect this may be the issue.

@thec0keman does the issue persist after rm -rf dist tmp?

I got the same issue trying to upgrading from 3.3.0 to 3.3.3. The issue persist even after rm -rf dist tmp. I went back to version 3.3.0 because version 3.3.1 seem to still have the error.

@ecoutlee-hortau could you share a list of other ember addons you're using (or preferably your package.json, if you're able to share)? That might be useful for reproducing this.

@maxfierke sure. It's with the .txt extension because Github don't allow me to upload a .json.
package.txt

The error message is a little different but seem similar enough to be the same issue:
Build Error (Funnel) ENOENT: no such file or directory, lstat '/home/ecoutlee/platform-webapp/tmp/funnel-input_base_path-BwXTIMfy.tmp/vendor/ember-tooltips--popper.js'

Thanks! I see you're also using ember-engines. Are you also using lazy-loaded engines?

Seem like we are using lazy-loaded engines.
Each engine have this line in their index.js:
lazyLoading: process.env.IS_TESTING !== 'true',

Sorry that I let this slip!

I'm seeing the same behavior after clearing tmp and dist. We are also using engines.

Was able to trace things down to this commit.

I'll do some playing around with lazy engines this week to take a look at fixing this!

I think I traced it back to a recent change in how vendor trees are built in ember-engines (ember-engines/ember-engines#646). There's some discussion on-going there about breakage in ember-cli-showdown, which is what ember-tooltips's treeForVendor implementation is based upon. I'll keep an eye on that thread for a bit, while I also try to figure out if there's a way to do what we want without using treeForVendor.

More details shared here: ember-engines/ember-engines#646 (comment)

I am also running into this issue, using engines with lazy loading

I just got a similar issue with ember-sortable. The owner pointed out it's probably related to ember-engines/ember-engines#400. Maybe it will help someone to find a solution to this issue.