single-spa / single-spa.js.org

Home Page:https://single-spa.js.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Browser Search marks minimized menus as find

Lalaluka opened this issue · comments

Using the Browser STRG+F search in the docs, it returns minimized/hidden menus as search results (even tho they are not visible).
I'm not sure, but it might be an issue with the used docusaurus version?

Example Results from "Getting Started with single-spa"
Bildschirmfoto 2021-12-26 um 21 30 46
Bildschirmfoto 2021-12-26 um 21 36 42

Menu State during the search:
Bildschirmfoto 2021-12-26 um 21 41 20

After extending, the search result counter (1/1) won't increase. But It will mark the menu occurrence.
Bildschirmfoto 2021-12-26 um 21 43 23
Bildschirmfoto 2021-12-26 um 21 45 04

Reproducible on:

  • Chrome 96.0.4664.55
  • Opera 74.0.3911.218
  • Edge 96.0.1054.62

Safari seems to work fine.

Agreed that this could be improved. I don't know the specifics of what browsers will find when searching via Ctrl / Cmd F. Is it just everything in the DOM? Or only things with certain css properties? Regardless, this should be raised as an issue in Docusaurus rather than here. I wasn't able to find any existing issue in docusaurus' queue for this, so perhaps you could create a new one?

https://github.com/facebook/docusaurus/issues