single-spa / single-spa.js.org

Home Page:https://single-spa.js.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Typo in single-spa-leaked-globals code example

rajasegar opened this issue · comments

The example for unmount array shows including leakedGlobalsLifecycles.mount, instead it should be
leakedGlobalsLifecycles.unmount in here, https://single-spa.js.org/docs/ecosystem-leaked-globals/

export const unmount = [
  leakedGlobalsLifecycles.mount,
  // Make sure leaked globals lifecycles' unmount function is **after** other lifecycles' unmount
  // This is so the global vars are still available during the framework unmount lifecycle function.
  frameworkLifecycles.unmount,
]

Expected behavior

export const unmount = [
  leakedGlobalsLifecycles.unmount,
  // Make sure leaked globals lifecycles' unmount function is **after** other lifecycles' unmount
  // This is so the global vars are still available during the framework unmount lifecycle function.
  frameworkLifecycles.unmount,
]

Thanks for the report - fixed in aff638f