single-spa / single-spa-vue

a single-spa plugin for vue.js applications

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

automatically integrate with vue devtools

joeldenning opened this issue · comments

See https://single-spa.slack.com/archives/CGGUQJMK6/p1586184682018500?thread_ts=1586160528.018200&cid=CGGUQJMK6

In vue-cli-plugin-single-spa, we should do this:

// Before you create app
Vue.config.devtools = process.env.NODE_ENV === 'development'

In single-spa-vue, we should automatically initialize the devtools with the following:

window.__VUE_DEVTOOLS_GLOBAL_HOOK__.Vue = instance.constructor

Closing this, as explained in #46

When you are planning a release of this? @joeldenning

nothing to release. see #46 (comment)

This issue was closed without making any changes to single-spa-vue. Vue devtools 5.3.3 fixed this issue and we no longer have to make any changes to single-spa-vue for it.

There are no unreleased changes in single-spa-vue -- our latest code was released in 1.8.2

Oops, I commented right after @frehner did. I didn't mean to double-team this one 😄

awesome, cheers.