sindresorhus / refined-twitter

Browser extension that simplifies the Twitter interface and adds useful features

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Clicking links in tweet modals does not open them

ivancuric opened this issue · comments

Clicking, middle-clicking, cmd-clicking links inside tweets while in a modal window does not open them. Works fine in the timeline/home view.

I just tried this and it's working fine. Can you provide more details?

It doesn't work for me either.

It worked just fine. Using the latest version from the extension.

untitled

First one is middle click and second one is +click

I've encountered this too.

Does the console reports anything? I'm unable to reproduce this issue :(

Chrome Version: 65.0.3325.181 (Official Build) (64-bit)
macOS Version: 10.13.3 (17D102)
Refined Twitter: compiled directly from the master branch

I can always reproduce this bug. It's fine when there's a preview, for example I can open the link in this tweet: https://twitter.com/sindre_gh_repos/status/982609042043367429 but it doesn't work with plain links and only when the tweet is open in a modal.

Chrome Version: 66.0.3359.117 (Official Build) (64-bit)
macOS Version: 10.13.4 (17E199)
Refined Twitter: 18.4.18.1421

I'll see if it works if I compile from the repo.

Okay, so I got the hang of this: If I open the link to the tweet directly, it works as expected. If I open the tweet details from the timeline, that's when it seems to break. I'll take a look to see if I can find the culprit. Thanks for the info, guys.

The culprit is commit 0b6e662. I'll try to fix this withouth removing the functionality.

This commit is also responsible for #98