refined-github / refined-github

:octocat: Browser extension that simplifies the GitHub interface and adds useful features

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Comment cancellation confirmation feature no longer needed?

sharkykh opened this issue · comments

Hello,

Seems like GitHub has incorporated the add-confirmation-to-comment-cancellation.js feature natively.

As can be seen on this GIF, the alert is shown twice.
When I disable the feature in refined-github's extension settings, it's only shown once.

This may need more confirmation, because I'm not sure as to the full scope of the feature.

GIF

2018-09-11_21-39-02

@lukehefson Is this a feature that GH accidentally added while adding resolve conversation feature?

lukehefson Is this a feature that GH accidentally added while adding resolve conversation feature?

@notlmn Nope. We shipped this purposefully as part of our Papercuts initiative. Apologies for not noticing the conflict here sooner! 😬