sindresorhus / gulp-rev

Static asset revisioning by appending content hash to filenames: `unicorn.css` → `unicorn-d41d8cd98f.css`

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incorrectly change some files (eg: dataTables.fixedHeader.js)

xiaoweibaniu opened this issue · comments

Description

use gulp-rev:

dataTables.fixedHeader.js => dataTables-236fe04c3a.fixedHeader.min.js

For these files, it did a wrong operation

Steps to reproduce

Are you suggesting that the result should be dataTables.fixedHeader.min-236fe04c3a.js instead of dataTables-236fe04c3a.fixedHeader.min.js?

As long as the manifest points to the right files, it shouldn't be an issue.

@zhouzi
it should be dataTables.fixedHeader.min-236fe04c3a.js.
it is now taTables-236fe04c3a.fixedHeader.min.js, and the manifest points to the right files. but,
When using gulp-rev-collector, it is not correct.

If the file paths are consistent across the filenames and the rev-manifest.json, then there is nothing wrong. It seems like your issue is with the gulp-rev-collector plugin -- not here.

FWIW, you can change how file names are constructed. Please see my previous answer on how to do so. You can setup the files however you want this way.


Marking as closed since this is intended behavior. However, please feel free to follow up with any questions. 😄