Giters

sindresorhus / electron-debug

Adds useful debug features to your Electron app

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Critical dependency: the request of a dependency is an expression

motin opened this issue · comments

commented

Webpack doesn't like them dynamic requires that electron-debug contains:

  WARNING in ./node_modules/electron-debug/index.js
  84:85-106 Critical dependency: the request of a dependency is an expression
   @ ./node_modules/electron-debug/index.js

Any chance they can be rewritten in a way that does not yield this warning when compiling with webpack?

commented

No, this should be fixed in Webpack.

commented

@sokra @TheLarkInn This is the gadzillion issue I've had to deal with about this warning. Please reopen webpack/webpack#196 and lets find a solution for this.