Generate on-the-fly .dmg icon based on Removable.icns and application icon
jtraulle opened this issue · comments
Hi, thanks for this great utilty 😃
Is there any way to specify a custom .icns for the dmg when it is mounted ?
It is confusing that it reuse app icon (as it is not the app but the volume).
Thanks 🥇
manrueda earned $100.00 by resolving this issue!
- Checkout the Issuehunt explorer to discover more funded issues.
- Need some help from other developers? Add your repositories on Issuehunt to raise funds.
The only the place icon is shown is in the title bar. I don't really see the problem or confusion of that.
Thanks for replying, mounted dmg appear on desktop as well and the icon is here.
Hmm, ok. I think I have disabled the desktop icons for mounted drives, so I never noticed.
I've worked very hard not to introduce any options here as I want it to just work. I think a better solution than an option is to dynamically create a disk image icon based on the app icon.
Something like:
Where the app icon is the macOS icon in the above example.
Yeah, that would be great 😃
I really appreciate your hard work to make the process very seamless 👍
Could be based on the official Removable.icns icon located at /System/Library/Extensions/IOStorageFamily.kext/Contents/Resources/Removable.icns with a light padding between the inlaid app icon (that maybe should be tilted a little to match the perspective of the Removable.icns icon) and the white background of the Removable.icns icon 😉
Agreed, that's perfect.
I'm busy at the moment, so I don't have time to implement this right now, but pull requests are welcome.
Could use jimp to composite the icons, but might need gm to be able to change the perspective.
Note to self: Might just be easier to write this part in Swift and call the Swift binary from Node.js.
I'm not very comfy with node.js stuffs (more a PHP man - don't blame me 😊 ), so I'll pass ...
Hope that someone find a moment sometime to address that 😉
In the meantime, I wish you good luck with your ongoing stuffs ☘️
I've made it stop using the app icon as DMG icon now, until this issue is resolved.
Thanks @sindresorhus 👍
@issuehuntfest has funded $100.00 to this issue. See it on IssueHunt
@manrueda has submitted a pull request. See it on IssueHunt
@sindresorhus has rewarded $90.00 to @manrueda. See it on IssueHunt
- 💰 Total deposit: $100.00
- 🎉 Repository reward(0%): $0.00
- 🔧 Service fee(10%): $10.00