Classic Style Application without a `config.ru` does not work with Ruby 3.3 and Bundler 2.5

Question

Classic Style Application without a `config.ru` does not work with Ruby 3.3 and Bundler 2.5

ukolovda opened this issue 5 months ago · comments

Steps to reproduce.

Source files:

# my_app.rb
require 'sinatra'

get "/ready" do
  "ready"
end

# Gemfile
source 'https://rubygems.org'

gem "sinatra"
gem "webrick"

# Gemfile.lock
GEM
  remote: https://rubygems.org/
  specs:
    mustermann (3.0.0)
      ruby2_keywords (~> 0.0.1)
    rack (2.2.8)
    rack-protection (3.1.0)
      rack (~> 2.2, >= 2.2.4)
    ruby2_keywords (0.0.5)
    sinatra (3.1.0)
      mustermann (~> 3.0)
      rack (~> 2.2, >= 2.2.4)
      rack-protection (= 3.1.0)
      tilt (~> 2.0)
    tilt (2.3.0)
    webrick (1.8.1)

PLATFORMS
  ruby
  x86_64-linux

DEPENDENCIES
  sinatra
  webrick

BUNDLED WITH
   2.5.3

Executing:

$ bundle
Bundle complete! 2 Gemfile dependencies, 8 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.

$ bundle exec ruby my_app.rb 
<No response, the application exit>

$ ruby -v
ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-linux]

Dmitry Ukolov · Answer 1 · Thu Dec 28 2023 03:58:44 GMT+0800 (China Standard Time)

With Ruby 3.2.2 it works fine:

$ bundle exec ruby my_app.rb 
[2023-12-27 23:57:08] INFO  WEBrick 1.8.1
[2023-12-27 23:57:08] INFO  ruby 3.2.2 (2023-03-30) [x86_64-linux]
== Sinatra (v3.1.0) has taken the stage on 4567 for development with backup from WEBrick
[2023-12-27 23:57:08] INFO  WEBrick::HTTPServer#start: pid=668884 port=4567
^C== Sinatra has ended his set (crowd applauds)
[2023-12-27 23:57:12] INFO  going to shutdown ...
[2023-12-27 23:57:12] INFO  WEBrick::HTTPServer#start done.

I try Puma instead of Webrick, result is the same - application exit.

Patrik Ragnarsson · Answer 2 · Thu Dec 28 2023 17:35:57 GMT+0800 (China Standard Time)

I see the same thing, thanks for providing sensible reproducible steps, maybe this is what #1966 was trying to say, and the culprit for #1971

Interestingly, 3.3.0-preview3 works fine (but not 3.3.0-rc1)

$ b
Bundler 2.5.0.dev is running, but your lockfile was generated with 2.5.3. Installing Bundler 2.5.3 and restarting using that version.
Fetching gem metadata from https://rubygems.org/.
Fetching bundler 2.5.3
Installing bundler 2.5.3
Fetching gem metadata from https://rubygems.org/....
Fetching webrick 1.8.1
Installing webrick 1.8.1
Bundle complete! 2 Gemfile dependencies, 8 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.

$ b exec ruby my_app.rb
[2023-12-28 10:32:46] INFO  WEBrick 1.8.1
[2023-12-28 10:32:46] INFO  ruby 3.3.0 (2023-11-12) [arm64-darwin21]
== Sinatra (v3.1.0) has taken the stage on 4567 for development with backup from WEBrick
[2023-12-28 10:32:46] INFO  WEBrick::HTTPServer#start: pid=27201 port=4567
^C== Sinatra has ended his set (crowd applauds)
[2023-12-28 10:32:50] INFO  going to shutdown ...
[2023-12-28 10:32:50] INFO  WEBrick::HTTPServer#start done.

Patrik Ragnarsson · Answer 3 · Thu Dec 28 2023 17:45:17 GMT+0800 (China Standard Time)

I adjusted the title here, Sinatra is working, what's not working is "Classic Style Application without a config.ru". Sinatra works perfectly fine when using config.ru: https://github.com/sinatra/sinatra#using-a-classic-style-application-with-a-configru

$ cat config.ru
require_relative 'my_app'
run Sinatra::Application

$ bundle exec rackup
[2023-12-28 10:40:19] INFO  WEBrick 1.8.1
[2023-12-28 10:40:19] INFO  ruby 3.3.0 (2023-12-25) [arm64-darwin21]
[2023-12-28 10:40:19] INFO  WEBrick::HTTPServer#start: pid=29835 port=9292
^C[2023-12-28 10:40:29] INFO  going to shutdown ...
[2023-12-28 10:40:29] INFO  WEBrick::HTTPServer#start done.

Patrik Ragnarsson · Answer 4 · Thu Dec 28 2023 18:19:29 GMT+0800 (China Standard Time)

Also sinatra/base without config.ru – https://github.com/sinatra/sinatra?tab=readme-ov-file#dynamic-application-creation – works:

$ cat app.rb
require 'sinatra/base'
my_app = Sinatra.new { get('/') { "hi" } }
my_app.run!

$ cat Gemfile
# frozen_string_literal: true

source "https://rubygems.org"

gem "sinatra", "~> 3.1"
gem "webrick", "~> 1.8"

$ b e ruby app.rb
[2023-12-28 11:09:36] INFO  WEBrick 1.8.1
[2023-12-28 11:09:36] INFO  ruby 3.3.0 (2023-12-25) [arm64-darwin21]
== Sinatra (v3.1.0) has taken the stage on 4567 for development with backup from WEBrick
[2023-12-28 11:09:36] INFO  WEBrick::HTTPServer#start: pid=38033 port=4567
^C== Sinatra has ended his set (crowd applauds)
[2023-12-28 11:09:43] INFO  going to shutdown ...
[2023-12-28 11:09:43] INFO  WEBrick::HTTPServer#start done.

Patrik Ragnarsson · Answer 5 · Thu Dec 28 2023 19:21:48 GMT+0800 (China Standard Time)

It is the combination of Ruby 3.3 and Bundler 2.5 that doesn't work

Ruby 3.3 works when Bundler 2.4.22 is used

$ bundler -v
Bundler version 2.4.22

$ bundle exec ruby my_app.rb
[2023-12-28 12:20:11] INFO  WEBrick 1.8.1
[2023-12-28 12:20:11] INFO  ruby 3.3.0 (2023-12-25) [arm64-darwin21]
== Sinatra (v3.1.0) has taken the stage on 4567 for development with backup from WEBrick
[2023-12-28 12:20:11] INFO  WEBrick::HTTPServer#start: pid=69122 port=4567
^C== Sinatra has ended his set (crowd applauds)
[2023-12-28 12:20:14] INFO  going to shutdown ...
[2023-12-28 12:20:14] INFO  WEBrick::HTTPServer#start done.

Patrik Ragnarsson · Answer 6 · Thu Dec 28 2023 21:02:38 GMT+0800 (China Standard Time)

This fixes the problem

diff --git a/lib/sinatra/base.rb b/lib/sinatra/base.rb
index 686d4d65..8fdfc935 100644
--- a/lib/sinatra/base.rb
+++ b/lib/sinatra/base.rb
@@ -1281,6 +1281,7 @@ module Sinatra
         %r{/sinatra(/(base|main|show_exceptions))?\.rb$},   # all sinatra code
         %r{lib/tilt.*\.rb$},                                # all tilt code
         /^\(.*\)$/,                                         # generated code
+        /\/bundled_gems.rb$/,                               # ruby >= 3.3 with bundler >= 2.5
         %r{rubygems/(custom|core_ext/kernel)_require\.rb$}, # rubygems require hacks
         /active_support/,                                   # active_support require hacks
         %r{bundler(/(?:runtime|inline))?\.rb},              # bundler require hacks

Patrik Ragnarsson · Answer 7 · Thu Dec 28 2023 21:52:56 GMT+0800 (China Standard Time)

with some debug printing (and the patch above)

Ruby 3.3.0 and Bundler 2.5.3 (the problematic combo)

$ bundle exec ruby my_app.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/bundled_gems.rb
ignore caller? true file=/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/bundled_gems.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/main.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/main.rb
ignore caller? true file=/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/bundled_gems.rb
ignore caller? true file=/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/bundled_gems.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra.rb
ignore caller? true file=/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/bundled_gems.rb
ignore caller? true file=/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/bundled_gems.rb
ignore caller? false file=my_app.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/main.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/main.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/main.rb
ignore caller? true file=/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/bundled_gems.rb
ignore caller? true file=/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/bundled_gems.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra.rb
ignore caller? true file=/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/bundled_gems.rb
ignore caller? true file=/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/bundled_gems.rb
ignore caller? false file=my_app.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra.rb
ignore caller? true file=/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/bundled_gems.rb
ignore caller? true file=/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/bundled_gems.rb
ignore caller? false file=my_app.rb
[2023-12-28 14:42:53] INFO  WEBrick 1.8.1
[2023-12-28 14:42:53] INFO  ruby 3.3.0 (2023-12-25) [arm64-darwin21]
== Sinatra (v3.1.0) has taken the stage on 4567 for development with backup from WEBrick
[2023-12-28 14:42:53] INFO  WEBrick::HTTPServer#start: pid=10727 port=4567

Ruby 3.2.2 and Bundler 2.5.3

$ bundle exec ruby my_app.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/main.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/main.rb
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra.rb
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>
ignore caller? false file=my_app.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/main.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/main.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/main.rb
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra.rb
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>
ignore caller? false file=my_app.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra.rb
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>
ignore caller? false file=my_app.rb
[2023-12-28 14:50:02] INFO  WEBrick 1.8.1
[2023-12-28 14:50:02] INFO  ruby 3.2.2 (2023-03-30) [arm64-darwin21]
== Sinatra (v3.1.0) has taken the stage on 4567 for development with backup from WEBrick
[2023-12-28 14:50:02] INFO  WEBrick::HTTPServer#start: pid=13750 port=4567

Ruby 3.3.0 and Bundler version 2.4.22

$ bundle exec ruby my_app.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/main.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/main.rb
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra.rb
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>
ignore caller? false file=my_app.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/main.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/main.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/main.rb
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra.rb
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>
ignore caller? false file=my_app.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra/base.rb
ignore caller? true file=/Users/dentarg/src/sinatra/sinatra/lib/sinatra.rb
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>
ignore caller? true file=<internal:/Users/dentarg/.arm64_rubies/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>
ignore caller? false file=my_app.rb
[2023-12-28 14:46:27] INFO  WEBrick 1.8.1
[2023-12-28 14:46:27] INFO  ruby 3.3.0 (2023-12-25) [arm64-darwin21]
== Sinatra (v3.1.0) has taken the stage on 4567 for development with backup from WEBrick
[2023-12-28 14:46:27] INFO  WEBrick::HTTPServer#start: pid=12602 port=4567

Patrik Ragnarsson · Answer 8 · Thu Dec 28 2023 22:47:39 GMT+0800 (China Standard Time)

Interestingly, 3.3.0-preview3 works fine (but not 3.3.0-rc1)

https://github.com/ruby/ruby/commits/v3_3_0/lib/bundled_gems.rb changed a few times between preview-3 and rc1 so any change after 2023-11-07 (ruby/ruby@76dc327eef) caused the change in behaviour

Patrik Ragnarsson · Answer 9 · Thu Dec 28 2023 23:23:11 GMT+0800 (China Standard Time)

https://github.com/ruby/ruby/commits/v3_3_0/lib/bundled_gems.rb changed a few times between preview-3 and rc1 so any change after 2023-11-07 (ruby/ruby@76dc327eef) caused the change in behaviour

Probably ruby/ruby@214f6d6