simplesteph / kafka-streams-course

Learn Kafka Streams with several examples!

https://www.udemy.com/kafka-streams/?couponCode=GITHUB

Shutdown Hook Unreachable

chrisccoy opened this issue 6 years ago · comments

Chris Coy commented 6 years ago

kafka-streams-course/word-count/src/main/java/com/github/simplesteph/udemy/kafka/streams/WordCountApp.java

Line 61 in 8cb61b0

Runtime.getRuntime().addShutdownHook(new Thread(streams::close));

Stephane Maarek commented 6 years ago

correct indeed
@chrisccoy do you want to submit a PR for this? can you please create two and target both master and 1.0 ?

Chris Coy commented 6 years ago

👍

Stephane Maarek commented 6 years ago

thanks a lot for the PRs @chrisccoy !
Happy learning :)