'error' stays true in 'options change detection' example

Question

rohan-rest-art opened this issue 3 years ago · comments

The examples block contains a link 'Options change detection':
https://codesandbox.io/s/axios-hooks-options-change-v23tl
I found an issue in this example.

How to reproduce:

Follow the link above.
Submit a request with user id '1'.
Shows data for user id '1'. Works good.
Submit a request with user id '2'.
Shows data for user id '2'. Works good.
Submit a request with user id '2222222222222222'.
Shows an error and data for user id '2'. Why hasn't 'data' changed? Looks weird but ok.
Submit a request with user id '1' again.
Shows an error and data for user id '1'. Why is 'error' still truthy?

Probably the issue has the same cause as #372

Simone Busoli · Answer 1 · Sun Feb 27 2022 20:56:43 GMT+0800 (China Standard Time)

Thanks for reporting this. This looks like a bug in the cache. Would you like to submit a PR to fix it?

Tom Ceuppens · Answer 2 · Tue May 17 2022 17:58:57 GMT+0800 (China Standard Time)

Its still a bug and a pretty annoying one. :/

Simone Busoli · Answer 3 · Wed Jun 01 2022 21:27:29 GMT+0800 (China Standard Time)

This is now fixed, lmk if the new version works for you