Regression? v3.0 produces huge JPG file again

Question

Regression? v3.0 produces huge JPG file again

EdiWang opened this issue 2 years ago · comments

Edi Wang commented 2 years ago

Describe the bug
The JPG is incorrectly encoded result to huge file size.

To Reproduce

Select "JPG" in "Save as"
Scan a document
Observe the file
The file is incorrectly encoded

Expected behavior
The file should be small size with JPG encoding

Screenshots

Edi Wang · Answer 1 · Mon Dec 13 2021 09:30:50 GMT+0800 (China Standard Time)

It seems to be a regression bug that I've fixed in v2 via #39

Edi Wang · Answer 2 · Mon Dec 13 2021 10:15:23 GMT+0800 (China Standard Time)

The bug was because in v3.0, this code is forgetting apply the correct JPG encoder option

Simon · Answer 3 · Tue Dec 14 2021 05:22:38 GMT+0800 (China Standard Time)

Hi there, I'm sorry this bug made another appearance - thank you very much for fixing it once again! I've wrapped all BitmapEncoder.CreateAsync()s in a new function so this shouldn't ever happen again.

As a side effect files may be a little too compressed right now (e.g. when further editing an already compressed file), which I'll check later.