Add runtime dependency on neo4j Python package

Question

Add runtime dependency on neo4j Python package

jnturton opened this issue 4 years ago · comments

James Turton commented 4 years ago

I think the README should tell users that we will need the Python Neo4j driver.

https://pypi.org/project/neo4j/

pip3 install neo4j

Benoit Simard · Answer 1 · Tue May 12 2020 00:51:53 GMT+0800 (China Standard Time)

Thanks for the feedback !.

In fact this module has two dependencies : neo4j driver & python-dateutil
https://github.com/sim51/neo4j-fdw/blob/master/setup.py#L11

Normally those deps are installed when you call python setup.py install as described in the doc (or with make install). No ?

But I see that neo4j-driver is deprecated in favor of just neo4j (just a rename of the lib name)

Installation from the neo4j-driver package on PyPI is now deprecated and will be discontinued in the 2.x series driver releases. Please install from the neo4j package instead.

I will change that.

James Turton · Answer 2 · Tue May 12 2020 02:02:09 GMT+0800 (China Standard Time)

Ah, okay. My installation procedure was a bit different and went

apt install postgresql-12-python3-multicorn
pgxn install neo4j-fdw

After that I had to figure out that the neo4j Python package was missing.

Benoit Simard · Answer 3 · Tue May 12 2020 05:19:52 GMT+0800 (China Standard Time)

Ho cool, this is my first feedback on the pgxn package.

I will check if it's possible to package the deps directly in pgxn, otherwise I update the doc.

Thanks !

Benoit Simard · Answer 4 · Fri Jul 24 2020 22:59:57 GMT+0800 (China Standard Time)

After checking, PGXN is calling "make & make install" that pretty much do a python ./setup.py install. So the deps are installed by PGXN.
I added a note in the readme.