The possibility to set custom success response codes

Question

The possibility to set custom success response codes

jonkri opened this issue 9 years ago · comments

I would like to be able to return a custom response code upon success, such as setting 303 See Other instead of 200 OK.

Thanks for a nice library!

Erik Hesselink · Answer 1 · Mon Jul 06 2015 17:49:01 GMT+0800 (China Standard Time)

That's a good idea. Do you have any idea how you would like the user API would look for this?

Adam Bergmark · Answer 2 · Mon Jul 06 2015 18:50:28 GMT+0800 (China Standard Time)

How about having a customResponseCode that introduces a ToResponseCode constraint on the output dictionary?

Erik Hesselink · Answer 3 · Mon Jul 06 2015 18:55:11 GMT+0800 (China Standard Time)

That sounds like a good idea, I'm not sure how it'd work out internally though. If it doesn't, another option would be to have a monadic setResponseCode inside the handlers. We'd have to change the type for the handlers, though, which is pretty nasty. If we ever do that (we've discussed it before) we should really make it opaque.

Jon Kristensen · Answer 4 · Fri Jul 24 2015 01:42:42 GMT+0800 (China Standard Time)

setResponseCode seems like the nicest to work with. The return type of handlers should perhaps be more structured, i.e. data HandlerReturn = HandlerReturn { returnBody :: !ByteString, returnCode :: !Int, returnHeaders :: !(Map HeaderName HeaderValue)}.