sikanhe / reason-graphql

GraphQL server in pure Reason (Bucklescript)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Suggestion: remove 'variations'

leeor opened this issue · comments

Motivation

Reduce the dependency footprint. Right now, due to RationalJS/future#53, I cannot update my bs-platform version to 8.

Since these variations are very simple and short, they could be documented instead of being a part of the source code. There's also the option of making each variation a separate npm module, but it might be overkill.

I'll be happy to submit a PR if you agree with this suggestion.

@leeor Seems good with me. Happy to accept PR.

1 Suggestion i have to is to prefer reason-promise over Future library - Future library does not handle event loop starvation properly, I regret adding it as example

PR merged, thanks @sikanhe.

Actually, #37 was closed without merging, so I'm reopening this.

In master - need to add back readme/guide - will open up a new issue for that