an Idea to improv
MuriloSF opened this issue · comments
Hey guys, your plugin is fucking AWESOME.
There is a huge improvement in performance instead of using JSON files method for Typography sync.
I have an idea, I don't know how easy will it be to implement it.
ISSUE
Ok, now we have a "typography library", but If I open an old file or if I change a Text style name It will lose all styles. ( I mean, you have to select every text layer one by one and select the Text Style for them.) If you have 8 Screens with many different text Styles, colors, sizes, aligments. People with definitely not update the styles at all, because it should be done in every update in the Text Library.
SOLUTION
I don't have a real one. But there is something that maybe works.
There is a plugin called "Select Similar Layers" with an option for "Fonts".
https://github.com/wonderbit/sketch-select-similar-layers
If you could in somehow use this selection of similar fonts in your plugin and apply or replace the style it will be a Sketch Text Library that Sketch guys are not able to do yet.
It could be an option like "Add/replace fonts with a similar Text Style".
I know you have already had a lot of work in this plugin. But solving this issue with this suggestion or with any other way you find out will make it the "Sketch Text Library" works perfect.
Thanks a lot for your attention and time.
Best,
Murilo
Hi @MuriloSF, thanks for your feedback and kind words! Yeah the issue of updating style names if they change in the library is on top of my list – shouldn't be too hard to solve necessarily, just gotta figure out the most common sense behaviour for it.
The second issue, where you want to apply library styles to an existing document, does that happen often in your workflow? And when it happens, do you already have some styles applied (just not the library ones), or do you have lots of layers with no styles applied at all?
Hey @sigtm, Thanks for your fast answer and to be open for feedbacks and suggestions.
1. where you want to apply library styles to an existing document, does that happen often in your workflow?
Yes, it happens really often. Mainly because we don't have a global Text Style, you have to sync again in every single file. If you copy and past you design to a new file for example it is already happening.
And it is also a new topic, everybody is testing and trying new Text Style names, hierarchy and arrangements. And if the library is work in progress and there are projects going on in parallel ( it is our case by the way ).
2. And when it happens, do you already have some styles applied (just not the library ones), or do you have lots of layers with no styles applied at all?
It happens in both situations,
Case 1 - if we change the name or structure ( that also affect the names ), there will be many Text Styles that have a new name and will not be linked.
Case 2 - As it is not a global Text Style for all the files, If you simple copy your design to a new file it already looses the text styles you are not using. So.. designers will use layers with no text style and then later apply the style to them.
Case 3 - As I mentioned before, when the Library is working in progress and there is projects in parallel, All the layers will have no Style even if they are in the correct size, font and colour.
Thanks again,
Murilo
@MuriloSF Great, thanks for the extra details :) It seems like there are two separate issues here:
-
Syncing styles which have a new name, for example due to the names and hierarchy being work in progress
-
Applying styles to an existing file for the first time
The first one is definitely a priority. As for the second one, I wonder if that's better solved by existing selection plugins than trying to incorporate their functionality into this one. So people might use the "Select similar layers" or "Presto Selecto" plugins to select a bunch of layers, and then apply a style to them after pulling in the library styles. Those plugins are already great at what they do, so I'm not sure I'll add any value by trying to replicate them :)
If you have equivalent styles by another name in a file that has never been synced, the Style Master plugin might be of interest. Then you'd just batch rename styles as needed to match the library styles, and then when you pull the library styles they will sync up:
@sigtm I understand your points and I thank you for the plugin link I will definitely try it out.
I also agree that Select Similar Layers is already a good plugin as well. The problem is that every time there are changes in the Text Library, every single member of the team has to select the layers (H1) and them apply the style, then (H2)... then (H3).. then (H4)... then (H5)... then (H6)... them (Paragraph)... then (Navegation text)... then (Helper text)... Still a lot of work to be repeating for every member of the team in every changing in the Text Library.
If it could be done by a plugin, Maybe if there is a plugin that search all your layers and link them to a Text Style if they fit it will not be that much work for every single change. I will search for it. If you know something in this direction I really appreciate.
Thanks So far for you time and attention,
Murilo