Implement a simple in-mem cache (with opt-in).
vaikas opened this issue · comments
Ville Aikas commented
A caching interface was implemented and by default it's implemented by just a placeholder. We should implement a simple in-memory cache to reduce hits on registry.
Interface:
https://github.com/sigstore/policy-controller/blob/main/pkg/webhook/cache.go#L47
And then it should be injected into the context somewhere around here based on flags:
https://github.com/sigstore/policy-controller/blob/main/cmd/webhook/main.go#L76
Hector Fernandez commented
@vaikas Should we include this issue into the v1 milestone ?
Ville Aikas commented
I think we should do it even before :) But sure!
…On Wed, Mar 8, 2023 at 8:35 AM Hector Fernandez ***@***.***> wrote:
@vaikas <https://github.com/vaikas> Should we include this issue into the
v1 milestone ?
—
Reply to this email directly, view it on GitHub
<#647 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACWB45HU66KAEUDUFC5W6B3W3CYM5ANCNFSM6AAAAAAVR4LFEA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>