Numbers in JSON result in reboot

Question

Numbers in JSON result in reboot

psi-4ward opened this issue 4 years ago · comments

Christoph Wiechert commented 4 years ago

␛[0;32mI (70039) MQTT: MQTT_EVENT_DATA␛[0m
assertion "IsString()" failed: file "/Users/sierenmusic/Development/HomeControl/main/libraries/rapidjson/include/rapidjson/document.h", line 1773, function: const Ch* rapidjson::GenericValue<Encoding, Allocator>::GetString() const [with Encoding = rapidjson::UTF8<>; Allocator = rapidjson::MemoryPoolAllocator<>; rapidjson::GenericValue<Encoding, Allocator>::Ch = char]
abort() was called at PC 0x40189b03 on core 0

ELF file SHA256: 18faed4d03d75adc

Backtrace: 0x4008685c:0x3ffd2460 0x40086c35:0x3ffd2480 0x40189b03:0x3ffd24a0 0x400ddaa0:0x3ffd24d0 0x400e008f:0x3ffd24f0 0x400e016d:0x3ffd2690 0x400e0279:0x3ffd2720 0x400e02f7:0x3ffd2790 0x400dda7d:0x3ffd27c0 0x400ddc51:0x3ffd27f0 0x400ddc89:0x3ffd2810 0x4011a1ea:0x3ffd2830 0x4011aac8:0x3ffd2850

Rebooting...

config:

    "name": "Temperatur b",
    "type": "Sensor",
    "icon": "door",
    "devices": [{
      "name": "Temp b",
      "type": "singleValue",
      "jsondata": true,
      "firstIcon": "temperature_small",
      "firstKey": "val",
      "getTopic": "hm/status/Wandthermostat:2/ACTUAL_TEMPERATURE"
    },

mqtt-payload:

{
  "val":3.1,
   "ts":1608319032692,
  "lc":1608306604934
}

Matt Sieren · Answer 1 · Tue Jan 05 2021 23:51:47 GMT+0800 (China Standard Time)

Thanks, that should not happen / it should accept all types in JSON.
I'll fix this soon.

Matt Sieren · Answer 2 · Wed Jan 06 2021 01:42:11 GMT+0800 (China Standard Time)

Which version were you running? And if so, can you give these binaries a try?

homepoint_release.zip

Christoph Wiechert · Answer 3 · Wed Jan 06 2021 01:50:22 GMT+0800 (China Standard Time)

Sorry I do not have the hardware anymore to run the tests

Henning Tvekov · Answer 4 · Wed Jan 06 2021 07:26:50 GMT+0800 (China Standard Time)

Hi' @sieren

I have (out of curiosity) tested with a text string as JSON attribute (ON or OFF) to be read.
This also crashes and force Homepoint to reboot.
Probably identical issue.

I run the 'September special' m5stack_full.bin version.

This example below reading a light state will crash Homepoint:

{
    "name": "TEST",
    "type": "Sensor",
    "icon": "door",
    "devices": [{
      "name": "TEST",
      "type": "singleValue",
      "firstIcon":"door_small",
      "jsondata": true,
      "firstKey": "state",
      "getTopic": "zigbee2mqtt/Office bed lamp"
    }]
  }

Ciao !

Henning Tvekov · Answer 5 · Fri Jan 08 2021 06:25:06 GMT+0800 (China Standard Time)

Hi' @sieren

Just downloaded and retested with Hp v0.05 (ESP_generic) and no crashes now reading non numerical JSON attributes 🙂🎉👍

Can read the state for eg. a light entity or whatever and it turns up nicely on the display.

One issue though:
In one of my tests I wanted to read the state of a light entity.
state attribute is returned, but its not the correct state attribute that is shown on the display.
Displayed state attribute is found one level down in JSON string.
The returned attribute is the state for update key which is idle.
The expected state attribute shown is ON

{"brightness":251,
"color":{"x":0.491,"y":0.39},
"linkquality":110,
"state":"ON",
"update":{"state":"idle"},
"update_available":false}

{
    "name": "Test json data",
    "type": "Sensor",
    "icon": "door",
    "devices": [{
      "name": "test",
      "type": "singleValue",
      "firstIcon":"wattage_small",
      "jsondata": true,
      "firstKey": "state",
      "getTopic": "zigbee2mqtt/Office desk lamp"
    }]
  }

Also tested with a boolean attribute returned.
Homepoint didn't crash but just shows 0.0 for both true and false attributes.

Could be nice if booleans was converted to On/Off or perhaps a different binary text expression (Yes/No, Out/Home, Open/Closed etc.) :-)

{"battery":100,
"illuminance":24,
"illuminance_lux":24,
"linkquality":55,
"occupancy":true,
"voltage":3005}

{
    "name": "Test json data boolean attribute",
    "type": "Sensor",
    "icon": "door",
    "devices": [{
      "name": "test",
      "type": "singleValue",
      "firstIcon":"wattage_small",
      "jsondata": true,
      "firstKey": "occupancy",
      "getTopic": "zigbee2mqtt/Office"
    }]
  }

Ciao !

Matt Sieren · Answer 6 · Tue Jan 12 2021 22:31:24 GMT+0800 (China Standard Time)

I think you've found a bug. Can you verify by updating your firmware with the OTA part (or flash from the ground up) ?
Attached a build to test.

(removed)

Henning Tvekov · Answer 7 · Wed Jan 13 2021 04:20:53 GMT+0800 (China Standard Time)

Hi' @sieren

Just made a quick test on the M5stack using OTA file.(last tests was made with the ESP_generic files)
Didn't know what to check for - so I tested for both issues reported :-)

Still crashes reading a true or false boolean value from occupancy json key.

MQTT publish: topic 'zigbee2mqtt/Office', payload '{"battery":100,"illuminance":0,"illuminance_lux":0,"linkquality":55,"occupancy":true,"voltage":3005}'

If i send a non valid boolean [truuuuue or falllse] or whatever it doesn't crash. So json key is parsed by HomePoint for sure.
Retested on 'standard' v0.05 and found that it also crashed on M5_stack_OTA ?
It didn't crash yesterday testing with ESP32_generic v0.0.5. Very strange...

state attribute read is also unchanged. Still shows idle attribute from update: {"state":} json key and not the expected ON attribute.

MQTT publish: topic 'zigbee2mqtt/Office desk lamp', payload '{"brightness":227,"color_temp":370,"linkquality":92,"state":"ON","update":{"state":"idle"},"update_available":false}'

Should I retest using the ESP32_generic files or are you confident that outcome should be identical ?

Ciao !

Matt Sieren · Answer 8 · Wed Jan 13 2021 05:20:43 GMT+0800 (China Standard Time)

Oh boy, yeah, apparently the M5Stack build failed after the build script refactoring in #132

Here's another build, this time specifically test for these two issues:
a) Should display "true" or "false" instead of crashing when a bool value is retrieved
b) Top level "state" key should be displayed

homepoint_release.zip

Henning Tvekov · Answer 9 · Wed Jan 13 2021 07:10:54 GMT+0800 (China Standard Time)

Hi' @sieren

That was a quick fix ! 😁

Nothing much to say than both issues are now solved 👍

Issue a)
true or false displayed ✔

Issue b)
Top level JSON key is displayed (ON or OFF for that specific state) ✔

Regarding issue b)
It could be nice to be able to specify a nested JSON key attribute to be retrieved by adding the full path.
I have some sensors that provide nested JSON attributes with identical key names.
It's quite typical for combines temp/hum/pres sensors I believe.
I've no idea about what the syntax should be or what parsing capabilities you actually have in HomePoint ?
(Not really into nested JSON's 😉)
e.g.

{
    "name": "Test json data",
    "type": "Sensor",
    "icon": "door",
    "devices": [{
      "name": "test",
      "type": "singleValue",
      "firstIcon":"wattage_small",
      "jsondata": true,
      "firstKey":  "\"update\":{\"state\"}",
      "getTopic": "zigbee2mqtt/Office desk lamp"
    }]
  }

Thank you, Matt.
Much appreciated 🙋‍♂️

Ciao !

Matt Sieren · Answer 10 · Wed Jan 13 2021 16:26:22 GMT+0800 (China Standard Time)

Can you provide me an example of the JSON Data there?

I might not get to this in the near future. Looks like the Zigbee2MQTT/HA Stuff is more important than this particular case?

Henning Tvekov · Answer 11 · Wed Jan 13 2021 23:23:17 GMT+0800 (China Standard Time)

Hi' @sieren

Sure thing 👍
I have several sensors that use nested JSON's. I'm afraid that it's quite common.

Outdoor lux sensor:

{"Time":"2021-01-13T14:39:33","BH1750":{"Illuminance":421}}

Greenhouse temp/hum/press. sensor:

{"Time":"2021-01-13T14:37:30","SI7021":{"Temperature":3.4,"Humidity":96.8,"DewPoint":2.9},"BMP280":{"Temperature":4.1,"Pressure":996.3},"PressureUnit":"hPa","TempUnit":"C"}}

I have no issue with these at the moment.
I can always send the needed data from Home Assistant via MQTT if needed.

I agree that the Z2M /HA stuff is much more interesting for other users than me 😉👍

CIao !