SETUP MVVM SKELETON

[Siddharth sharma]

setup MVVM architecture with empty classes

[Azeem Siddiqui]

@sidsharma2002 , Can you please elaborate this.

[Siddharth sharma]

Repository classes and room database with the use of hilt will complete the MVVM architecture

[Azeem Siddiqui]

If I introduce the concept of repository with Dagger Hilt, this needs to be modify the whole app, and make changes in most of the files.

[Siddharth sharma]

not in every class. setup hilt create an empty repository inject it into ViewModelA.kt. that's it. Change only ViewModelA, do you want me to assign you this issue?

[Azeem Siddiqui]

Yes Please Assign me this issue, ]is it included in HacktoberFest?

…

On Mon, Oct 4, 2021 at 9:32 PM Siddharth sharma ***@***.***> wrote: not in every class. setup hilt create an empty repository inject it into ViewModelA.kt. that's it. Change only ViewModelA, do you want me to assign you this issue? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJTKGGU5ZEGKGH3PS7DABG3UFHFZFANCNFSM5E4S4CJA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[Siddharth sharma]

yes it is

[Azeem Siddiqui]

Thanks for assigning this issue to me. I have created a new branch for this implementation named "issue_1_setup_mvvm", is it ok or should I make changes in the master branch?

[Siddharth sharma]

No you have done correctly. It is how a pr is expected to be made just make sure you create one pr pr commit. Meaning your pr should only contain one commit