talos installer fails on disks wiped with `wipefs`
frezbo opened this issue · comments
Noel Georgi commented
Talos installer fails to install on disks wiped with wipefs -a <device>
The Sidero agent successfully wiped the disk and marked as clean
20.503050] [talos] pulling "ghcr.io/talos-systems/installer:v0.13.2"
[ 31.201521] [talos] service[containerd](Running): Health check failed: rpc error: code = DeadlineExceeded desc = context deadline exceeded
[ 35.241785] [talos] service[containerd](Running): Health check successful
[ 37.856732] vcc-sd: disabling
[ 229.422871] 2021/11/17 09:58:07 running Talos installer v0.13.2
[ 229.543755] Error: expected signature of "EFI PART", got "\x00\x00\x00\x00\x00\x00\x00\x00"
[ 229.552239] Usage:
[ 229.554339] installer install [flags]
[ 229.558255]
[ 229.559809] Flags:
[ 229.561976] -h, --help help for install
[ 229.566274]
[ 229.567817] Global Flags:
[ 229.570706] expected signature of "EFI PART", got "\x00\x00\x00\x00\x00\x00\x00\x00"
[ 229.578884] --arch string The target architecture (default "arm64")
[ 229.587630] --board string The value of talos.board (default "none")
[ 229.596298] --bootloader Install a booloader to the specified disk (default true)
[ 229.606252] --config string The value of talos.config
[ 229.613431] --disk string The path to the disk to install to
[ 229.621426] --extra-kernel-arg stringArray Extra argument to pass to the kernel
[ 229.629496] --force Indicates that the install should forcefully format the partition
[ 229.640046] --platform string The value of talos.platform
[ 229.647289] --upgrade Indicates that the install is being performed by an upgrade
[ 229.657311] --zero Indicates that the install should write zeros to the disk before installing
[ 229.668719]
[ 229.743646] [talos] task install (1/1): failed: task "upgrade" failed: exit code 1
[ 229.751394] [talos] phase install (4/13): failed
[ 229.756169] [talos] install sequence: failed
Andrey Smirnov commented
I think we should check for both PMBR and EFI signature. If any of that is missing, disk is not partitioned. Today we seem to only care that PMBR is there.