Uncaught Error: bytes.Buffer: too large
ryangoodrich opened this issue · comments
The markdown file being edited is 50 lines long with each line less then 80 characters. Please let me know if I can provide any more information to you that would prove useful in debugging.
Thanks
What happened? Did you close this because it's no longer an issue?
I disabled your plugin and produced the same error on another .md file I was working in. Not sure what is causing the error but I no long believe it is related to your plugin.
I think it likely is.
Is the issue reproducible? Can you share the .md file where it happened?
Also, what version of markdown-format package are you running? Just want to make sure I know.
I just created a new file and was able to produce the same error.
###### Test
# Header
comments about the header go in here
I am using 2.3.0
That is really odd, I definitely can't reproduce it with that input. See here.
How many other Atom packages do you have? Is it the latest version of Atom? Hmm.
Have you tried quitting Atom and restart it since the error happened? Maybe it keeps happening from the original bad input. If you could share the larger file when it happened first, that'd be great.
I tried restarting before, and then ran the initial file and got the same error. I just restarted again and tried the file I sent you, no error. Go back to the initial file, and get the same error. Here is a dropbox link to the file, see if you can get it to reproduce on your computer: file
Yes, I can reproduce with that file. Thanks! I'll work on fixing this over the next few days.
Awesome! Let me know if I can do anything to help.
I'm seeing this too. Let me know if you need a file
Yeah, this is a pretty serious regression. It happens on 2.3.0 even with input as small as:
###### PHP
File
====
A php file opens with <?php tags and has a file sufix of .php.
```
// create a new file called "test.php" and return the handle for the file
// to allow the creation of other items
$file = new File('test');
```
But 2.2.0 is okay.
Okay, it seems to be a regression in current GopherJS that I used to compile to JavaScript. I've reverted to using an older known good version of GopherJS, which seems to fix this problem, so I've pushed that as a patch version 2.3.1.
Please try it out and let me know if you still find this issue reoccurring; I cannot reproduce it with 2.3.1 so far.
I've opened gopherjs/gopherjs#92 to hopefully find and fix the issue upstream.
We've identified the root cause in gopherjs/gopherjs#92 and I've fixed the issue in shurcooL/markdownfmt@4cd4887. Version 2.3.1 does not suffer from it, and future releases of atom-markdown-format shouldn't either.
Closing this.
Thanks again for reporting the issue so quickly when it came up, by the way!
No problem. I'm glad you were able to get it resolved.
—
Reply to this email directly or view it on GitHub.