showyourwork / showyourwork

A workflow for reproducible and open scientific articles

Home Page:https://show-your.work

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

snakemake 7.15.2 does not work with pulp 2.8.0

thomasckng opened this issue · comments

showyourwork install snakemake 7.15.2 currently and it calls pulp.list_solvers in snakemake/init.py line 1471 get_argument_parser. That function is changed to pulp.listSolvers in pulp 2.8.0. Github action install pulp 2.8.0 now, as the requirement is just pulp>=2.0. Newer version of snakemake is compatible with pulp 2.8.0. Maybe we can change the dependency to a newer version of snakemake or restrict the version of pulp?

Thanks! I see this behavior too. I think the preferred approach would be to add an upper limit on the version of pulp here:

"snakemake==7.15.2",

Because there are compatibility issues with the most recent versions of snakemake (ref: #264).

Would you be able to open a PR? Thanks!

Closed in #433. Thanks @thomasckng!