showyourwork / showyourwork

A workflow for reproducible and open scientific articles

Home Page:https://show-your.work

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`config['user_args']` was removed by #266

MilesCranmer opened this issue · comments

@dfm the PR #266 deleted some of the config options. I think this was a mistake because the config options are still documented and parsed from the config file, and are necessary for configuring tectonic.

Before the refactor, in the file tex.py, there were some extra config options:

force_args = [
"--chatter",
"minimal",
"--keep-logs",
"--keep-intermediates",
"-o",
f'"{output_dir}"',
]

f"{conda_activate} tectonic {' '.join(args)} {' '.join(force_args)} {' '.join(config['user_args'])} \"{paths.user().repo / config['ms_tex']}\"",

However, after the refactor, only the contents of force_args remains:

tectonic \\
--chatter minimal \\
--keep-logs \\
--keep-intermediates \\
--synctex \\
"{input[0]}"

So any options I pass for tectonic_args (which is loaded to 'user_args') are simply dropped.

I think #317 raised an issue about some of these missing config options, but other ones are still missing...

Was this a planned deprecation or should we fix it? 😄