Shouldly should not add tons of dependencies
taori opened this issue · comments
There's a ton of odd dependencies introduced by the upgrade from 3x to 4x
I get that DiffEngine and EmptyFiles probably makes sense, but things like
Registry, MEF, ConfigurationManager, SqlClient and all the other seem pretty weird. Was there any thought put into crosscompiling so there are less dependencies?
i dont know why nuget is resolving that list. the actual count of dependencies for shouldly is only 4 https://www.nuget.org/packages/Shouldly
- DiffEngine (>= 6.4.9)
- EmptyFiles (>= 2.3.3)
- Microsoft.CSharp (>= 4.7.0)
- System.Memory (>= 4.5.4)
so perhaps raise it with the nuget team?
After a brief investigation i would assume the original offender here is https://www.nuget.org/packages/DiffEngine/6.4.9
Edit: It most certainly is: https://www.nuget.org/packages/Microsoft.Windows.Compatibility/
So the issue is the reference to DiffEngine possibly adding that dependency possibly without the need to do so (not sure what it does. but at least for netstandard2.1 the API changes compared to net5.0 should be minor according to the dev blogs
happy accept a PR to diffengine that reduces the number of dependencies
Yeah. Will look into that shortly. Just writing an issue @diffengine atm so it is tracked.
hopefully this should fix it #827
@SimonCropp @slang25 Thanks for the quick fix.
When is this going to be published though? - Last nuget package update was 10months ago. Is CI broken or is the project in a "collection features and fixes" state?
@taori i am not a core maintainer or this project. so i have no idea