Cut down on PR noise and provide easy, fast feedback to contributors by adding *a few* StyleCop Analyzers rules
jnm2 opened this issue · comments
@shouldly/core Would you mind if I turn on a few rules provided by StyleCop? Having contributed myself to repositories that have these rules in place, it's really nice having inline prompts and Ctrl+. light bulb fixes so that I don't spend time thinking about the codebase style to guess it up front, or spend time talking about it in my PRs.
These are some of my pet peeves that I don't want to bug PR contributors about after the PR is already up:
-if(condition)
+if (condition) Foo();
-
}However, I strongly disagree with over half the StyleCop Analyzers rules, such as always requiring braces, so I would not be enabling rules that don't seem fairly universal. I'd provide a pull request with one commit per rule I enable so that we can drop any that worry you.
@shouldly/core I'm planning to work on this soon just because of the number of formatting oversights in PRs. I don't want to give up and not address them, but I also don't want to spend time talking about it in PRs. With StyleCop, the instant feedback and light bulb fixes means we can have the cake and eat it too.