models.ts isJSONRPCResponse logic hole intentional?

Question

models.ts isJSONRPCResponse logic hole intentional?

okaihc opened this issue 5 years ago · comments

The following logic allows a variety of badly formatted JSON string to be reported back as valid JSON-RPC response.

export const isJSONRPCResponse = (payload: any): payload is JSONRPCResponse => {
return !isJSONRPCRequest(payload);
};

Also even if I patched it up to confirm that payload is neither Response nor Request, receiveAndSend() does not reject. Not sure if this was intentional but it seems it would be good to be able to use a .catch with receiveAndSend() when payload is neither Response nor Request?

Shogo Wada · Answer 1 · Wed Jul 24 2019 20:15:11 GMT+0800 (China Standard Time)

You are right. Both issue are fixed with json-rpc-2.0@0.2.10.

Thanks

okaihc · Answer 2 · Thu Jul 25 2019 05:10:10 GMT+0800 (China Standard Time)

Works beautifully! Thanks!
BTW this is the only javascript/typescript library I can find that does JSON-RPC 2.0 bi-directionally over a single WebSocket connection AND completely separates the transport from the RPC protocol. It allows me to do things like use more than one protocol on the same WebSocket connection and still have access to the raw WebSocket for whatever funny reason I have...thanks for posting this project.