RuntimeWarning: coroutine 'RFC1459Support._registration_completed' was never awaited
Harmon758 opened this issue · comments
This occurs on
https://github.com/Shizmob/pydle/blob/a7053805cfbeec78ce7d30ea359a775c5ea1200e/pydle/features/rfc1459/client.py#L943 as _registration_completed is a coroutine that's not awaited:
https://github.com/Shizmob/pydle/blob/a7053805cfbeec78ce7d30ea359a775c5ea1200e/pydle/features/rfc1459/client.py#L217
Resolved for v0.9.0
This is still happening to me on 0.9.1
It seems like ctcp_reply is not awaited
async def on_ctcp_version(self, by, target, contents):
""" Built-in CTCP version as some networks seem to require it. """
import pydle
version = '{name} v{ver}'.format(name=pydle.__name__, ver=pydle.__version__)
self.ctcp_reply(by, 'VERSION', version)@LiraNuna Looks like your issue is unique to this one, would you mind making a new issue ticket?
Looking at the source you are indeed correct about a missing await, however I can also see a few issues with the ctcp_reply that I will need to resolve to make this work properly.
Actually, looks like i already resolved these in #118 , I will have a bug fix released shortly.
Thank you for the quick reply!
@LiraNuna should be resolved in the release 0.9.2, please upgrade your local pydle version and verify your issue is now resolved?
Verified! Thank you for the quick fix!
No worries, my apologies for not releasing the fix sooner 😓