shizmob / pydle

An IRCv3-compliant Python 3 IRC library.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Errors with development mode - missing await in pydle.features.account?

Stary2001 opened this issue · comments

When running pydle with Python development mode enabled, errors like this appear in the program output.

 asyncio [ERROR] <CoroWrapper AccountSupport.whois() running at /home/bridge/venv/lib/python3.8/site-packages/pydle/features/account.py:25, created at /home/bridge/venv/lib/python3.8/site-packages/pydle/features/account.py:22> was never yielded from
 Coroutine object created at (most recent call last, truncated to 10 last lines):
   File "/home/bridge/venv/lib/python3.8/site-packages/aiorun.py", line 267, in run
     loop.run_forever()
   File "/usr/lib/python3.8/asyncio/base_events.py", line 570, in run_forever
     self._run_once()
   File "/usr/lib/python3.8/asyncio/base_events.py", line 1851, in _run_once
     handle._run()
   File "/usr/lib/python3.8/asyncio/events.py", line 81, in _run
     self._context.run(self._callback, *self._args)
   File "/home/bridge/venv/lib/python3.8/site-packages/pydle/features/ircv3/ircv3_2.py", line 82, in on_raw
     await super().on_raw(message)
   File "/home/bridge/venv/lib/python3.8/site-packages/pydle/client.py", line 422, in on_raw
     await handler(message)
   File "/home/bridge/venv/lib/python3.8/site-packages/pydle/features/rfc1459/client.py", line 660, in on_raw_nick
     self._rename_user(nick, new)
   File "/home/bridge/venv/lib/python3.8/site-packages/pydle/features/ircv3/ircv3_1.py", line 22, in _rename_user
     super()._rename_user(user, new)
   File "/home/bridge/venv/lib/python3.8/site-packages/pydle/features/account.py", line 22, in _rename_user
     self.whois(new)

self.whois is async, and it doesn't await it.. but it can't just do that because _rename_user isn't async.
I'm not sure about the best way to fix this so I'm just filing an issue.
This occurs with pydle 0.9.4.