shizmob / pydle

An IRCv3-compliant Python 3 IRC library.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Error on ping timeout

Harmon758 opened this issue · comments

C:\Program Files\Python37\lib\asyncio\events.py:88: RuntimeWarning: coroutine 'BasicClient._perform_ping_timeout' was never awaited
  self._context.run(self._callback, *self._args)

This is due to https://github.com/Shizmob/pydle/blob/a7053805cfbeec78ce7d30ea359a775c5ea1200e/pydle/client.py#L375-L376 where call_later is used to schedule a coroutine instead of a callback.

Yep. Since connect is a coroutine now call_later is the wrong call to make.
I see a few issues with this routine, I will see to a fix today.

I have done some testing and fixed various bugs in the reconnection code, could you please attempt to reproduce against #102 ?

I'm not sure how connect is related, but using create_task and a sleep resolves this specific issue.

Ah, my apologies i mixed this bug up with #101 .
There were a fair few bugs in the reconnection handling code I worked through today.

In theory it should all be working now barring the password-protected server bug. Please do let me know if you manage to break reconnection while testing against 102