shiyiya / oplayer

:zap: Another HTM5 video player.

Home Page:https://oplayer.vercel.app

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Recommended to give each element a unique name to avoid custom styling errors caused by updated versions.

eritpchy opened this issue Β· comments

πŸš€ Feature Proposal

Recommended to give each element a unique name to avoid custom styling errors caused by updated versions.

Motivation

image

$('.css-s9s35s') ???
so ugly...

Example

image

$('#oplayer-icon-settings')
😍😍😍

Pitch

Why does this feature belong in the oplayer ecosystem?

commented

For style isolation, subsequent updates that do not involve styles will not change the hash value

image image

For example: what if.. you fix controlBarTitle margin error, css hash value will changed?

commented

εͺθƒ½εšε–θˆοΌŒζœ‰εΌŠη«―δΉŸζœ‰ε₯½ε€„οΌŒζ¬’迎prοΌŒζœ€θΏ‘ζ²‘η©ΊδΊ†

ε₯½ηš„ε§πŸ‘Œ

commented

image image
For example: what if.. you fix controlBarTitle margin error, css hash value will changed?

fixed @oplayer/ui@1.2.34-beta.3