Giters

shivammathur / setup-php

GitHub action to set up PHP with extensions, php.ini configuration, coverage drivers, and various tools.

Home Page:https://setup-php.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Configure `COMPOSER_PROCESS_TIMEOUT`

Bilge opened this issue · comments

commented

Describe the feature
Configure COMPOSER_PROCESS_TIMEOUT.

Version

  • I have checked releases, and the feature is missing in the latest patch version of v2.

Underlying issue
I just had two composer test jobs fail on GitHub Actions after a 6 hours timeout (the maximum allowed), burning through 720 minutes of allowance for no reason, all because this action quietly disables the timeout feature entirely. This is not safe or a good idea; the timeout is enabled by default for good reason. Regardless of whether you agree, this should be configurable.

Describe alternatives
I could probably manually override the timeout in each step or command where I require the timeout, though doing so would be laborious and hacky.

Are you willing to submit a PR?
No, I don't know TypeScript or how to test actions in development.

commented

I would not change it as that would be a breaking change, but support for COMPOSER_PROCESS_TIMEOUT env can be added.

commented

Yes, that is what I was driving at.

commented

Added support in a6ce3f5. Will be in next release.

commented

Released in 2.30.0.