shivammathur / setup-php

GitHub action to set up PHP with extensions, php.ini configuration, coverage drivers, and various tools.

Home Page:https://setup-php.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Debug symbols not included in libphp 8.3 ZTS even when debug set to true

dunglas opened this issue · comments

Describe the bug
libphp8.3.so ZTS is stripped even when debug is true.

Version

  • I have checked releases, and the bug exists in the latest patch version of v1 or v2.
  • v2
  • v1

Runners

  • GitHub Hosted
  • Self Hosted

Operating systems
Ubuntu 22.04.3 LTS

PHP versions
PHP 8.3 nightly

To Reproduce

     -
        uses: shivammathur/setup-php@v2
        with:
          php-version: 8.3
          ini-file: development
          coverage: none
          tools: none
        env:
          phpts: ts
          debug: true

Expected behavior
Debug symbols should be included.

Screenshots/Logs

$ file /usr/lib/libphp8.3.so
/usr/lib/libphp8.3.so: ELF 64-bit LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked, BuildID[sha1]=0aaebe820406e66a76acb2588689bc16bbd023dc, stripped

Additional context
n/a

Are you willing to submit a PR?
yes

@dunglas

Fixed in shivammathur/php-builder@66b1f71

The file command would still say stripped at the end, but the debug files should be there in the correct directory in /usr/lib/debug/ and the debugger should pick debuginfo from them.

Test workflow: https://github.com/shivammathur/test-setup-php/actions/runs/6902553939/workflow

Thank you!