Incomplete livestatus broker
chaen opened this issue · comments
chaen commented
Hi,
While trying to do some benchmarks, I realized that the 'GET status' query of the livestatus module was returning wrong information (for example, always 0 for the service_checks_rate).
Looking at the code of shinken/modules/livestatus_broker/mapping.py I found this :
'requests': {
'description': 'The number of requests to Livestatus since program start',
'function': lambda item, req: 0, # REPAIRME
'datatype': int,
},
'requests_rate': {
'description': 'The averaged number of request to Livestatus per second',
'function': lambda item, req: 0, # REPAIRME
'datatype': float,
},
'service_checks': {
'description': 'The number of completed service checks since program start',
'function': lambda item, req: 0, # REPAIRME
'datatype': int,
},
'service_checks_rate': {
'description': 'The averaged number of service checks per second',
'function': lambda item, req: 0, # REPAIRME
'datatype': float,
},
So it perfectly explains why I always got 0 :D
However, I was wondering if this would be corrected anytime soon? service_checks and service_checks_rate are in my opinion among the most useful information you can get out of livestatus when doing a benchmark.
Thanks a lot!
Chris
Original ticket : shinken-solutions/shinken#963