Giters

shinken-monitoring / mod-livestatus

Shinken module for presenting data with a MK/Livestatus comptabile interface

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

pylint and livestatus broker

Seb-Solon opened this issue · comments

commented

Comes from shinken-solutions/shinken#549 :

While looking at pylint output for issue #373, i've found these 2 errors in livestatus :

  • The easy one, we have to remove the columns method, don't we ?
    shinken/modules/livestatus_broker/livestatus_query_metainfo.py:304: [E, LiveStatusQueryMetainfo.columns] An attribute affected in shinken.modules.livestatus_broker.livestatus_query_metainfo line 159 hide this method
  • The not too easy one. It's looks like livestatus haven't been updated with new filters methods
    shinken/modules/livestatus_broker/livestatus_wait_query.py:179: [E, LiveStatusWaitQuery.launch_query] No value passed for parameter 'cs' in function call

commented

I gave a look at that..

first point seems now ok : I don't see any columns method in metainfo

second point : I don't see "cs" anymore in LiveStatusWaitQuery.launch_query signature..

we close ?