Giters

shinken-monitoring / mod-livestatus

Shinken module for presenting data with a MK/Livestatus comptabile interface

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add Tags Colums for Hosts and Services

DessaiImrane opened this issue · comments

commented

Hi,

I try to find which Tags are applied to Hosts or Services using LiveStatus

But this Column is not here.

I know Livestatus is mainly for Thruk/MkSite compatibilty. But as the Shinken inner API is not already fully implemented, I think it can be done easily in LiveStatus

If you guide me, I can try to send a PR

What do you think ?

commented

If I'm not wrong this was alrady merged some week/days ago. Can you give a
look at the master version?

On Wed, Jul 2, 2014 at 6:49 AM, DessaiImrane notifications@github.com
wrote:

Hi,

I try to find which Tags are applied to Hosts or Services using LiveStatus

But this Column is not here.

I know Livestatus is mainly for Thruk/MkSite compatibilty. But as the
Shinken inner API is not already fully implemented, I think it can be done
easily in LiveStatus

If you guide me, I can try to send a PR

What do you think ?

—
Reply to this email directly or view it on GitHub
#29.

commented

No "Tags" in master

Do I have to add somethings like that just here : https://github.com/shinken-monitoring/mod-livestatus/blob/master/module/mapping.py#L745

    'tags': {
            'description': 'Host Tags',
            'function': lambda item, req: item.tags,
            'datatype': list,
        },

It seems thats there is no "tags" property for "service", only "host_tags". Is this wanted or just a "not implemented property " ?

Thanks

commented

That's because service templates are not so useful. The main thing about
tags is for searching hosts or linking services and properties (contacts,
etc).

but for service you don't really care about search (you search for hosts,
less for service) and properties are a configuration part, so not really
for livestatus.

So go for host tags, but I'm wondering if it's really useful for services
in fact :)

On Thu, Jul 3, 2014 at 6:45 AM, DessaiImrane notifications@github.com
wrote:

No "Tags" in master

Do I have to add somethings like that just here :
https://github.com/shinken-monitoring/mod-livestatus/blob/master/module/mapping.py#L745

"""
'tags': {
'description': 'Host's Tags',
'function': lambda item, req: item.tags,
'datatype': list,
},
"""

It seems thats there is no "tags" property for "service", only
"host_tags". Is this wanted or just a "not implemented property " ?

Thanks

—
Reply to this email directly or view it on GitHub
#29 (comment)
.

commented

The only case I've met, is when I tried to debug template applied to some services to see if the were properly configured instead of reading again the conf.

Ok pour Tags for Hosts but I have no idea whether the snippet publish above is good or not :p

commented

Should be I think :)

On Thu, Jul 3, 2014 at 10:00 AM, DessaiImrane notifications@github.com
wrote:

The only case I've met, is when I tried to debug template applied to some
services to see if the were properly configured instead of reading again
the conf.

Ok pour Tags for Hosts but I have no idea whether the snippet publish
above is good or not :p

—
Reply to this email directly or view it on GitHub
#29 (comment)
.

commented

Thanks

On Fri, Jul 4, 2014 at 6:38 AM, DessaiImrane notifications@github.com
wrote:

Closed #29
#29 via
a9bc921
a9bc921
.

—
Reply to this email directly or view it on GitHub
#29 (comment)
.