`transformerNotationDiff` and `transformerNotationHighlight` don't apply any styles to code blocks
francisko-rezende opened this issue · comments
Validations
- Follow our Code of Conduct
- Read the Contributing Guide.
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
Describe the bug
The transformers transformerNotationDiff and transformerNotationHighlight don't seem to be working. From what I've gathered, they do add their respective classes to the tags related to the code blocks but the classes don't seem to have any css rules, resulting in no visual changes to the lines that were supposed to be transformed.
Cheers and thanks for the awesome work you've been doing in this project :)
Reproduction
https://stackblitz.com/edit/vitejs-vite-rzz2qj?file=main.js
Contributes
- I am willing to submit a PR to fix this issue
- I am willing to submit a PR with failing tests
It doesn't come with styles, it only transforms the markup and it's up to users to write the CSS themself.
Oh cool, thanks for the reply @antfu ! In that case may I suggest that that the docs make it a bit more explicit, specially in the section on Transformers? For instance, this bit makes me think that the styles are baked in
I'd gladly add a suggestion if that's alright :)
Cheers and thanks again
Of course! Would you like to send a quick PR to improve the docs? Thanks
Sure thing, it'll be a pleasure! I'll get to it ASAP :D