Directly find out Dart_PostCObject function pointer, instead of manually letting Dart to call Rust's store_dart_post_cobject?

Question

Directly find out Dart_PostCObject function pointer, instead of manually letting Dart to call Rust's store_dart_post_cobject?

fzyzcjy opened this issue 3 years ago · comments

Hi thanks for the lib! Looking at https://github.com/dart-lang/sdk/blob/master/runtime/include/dart_api_dl.h , I guess a C++ programmer will simply #include this header and then use the extern Dart_PostCObject_Type Dart_PostCObject_DL; directly. So what about removing store_dart_post_cobject and directly do that?

I can make a PR.

related: dart-lang/sdk#47356

shekohex · Answer 1 · Sat Oct 02 2021 15:49:12 GMT+0800 (China Standard Time)

can you explain more? what are you trying to achieve here?

fzyzcjy · Answer 2 · Sat Oct 02 2021 16:33:15 GMT+0800 (China Standard Time)

I find it probably not feasible. So please ignore this issue until I get reply from the related dart sdk issue.

By the way, #12 is NOT the same as this issue. That PR is merely using a lib to remove a unsafe call.