Plugin breaks sourcemaps on Google Chrome

Question

Plugin breaks sourcemaps on Google Chrome

sprguillen opened this issue 6 years ago · comments

Simon Phillip Guillen commented 6 years ago

As stated in the README: This plugin runs babel and rollup only once per asset, at the end of the compilation process.

Works like a charm as it runs my VueJS app on IE but the problem is that it breaks sourcemaps on Chrome: here's a more elaborate article on stackoverflow.

Maybe you can address this if you have plans to update the module. Thanks!

Adam Stankiewicz · Answer 1 · Tue Nov 13 2018 16:35:24 GMT+0800 (China Standard Time)

Maybe you want to prepare and test the fix? I forked from other project where PR fixing this is available: https://github.com/simlrh/babel-webpack-plugin/pull/2/files

Simon Phillip Guillen · Answer 2 · Tue Nov 13 2018 22:41:29 GMT+0800 (China Standard Time)

You mean I'll use babel-webpack-plugin in-conjunction with targets-webpack-plugin?

Adam Stankiewicz · Answer 3 · Tue Nov 13 2018 22:54:41 GMT+0800 (China Standard Time)

I mean to submit PR to this repository fixing this issue. You can find fix for repository I forked from in the link I've sent before

Adam Stankiewicz · Answer 4 · Tue Nov 13 2018 22:55:07 GMT+0800 (China Standard Time)

The issue is not with PR but with testing if it really works and that could be your part

Simon Phillip Guillen · Answer 5 · Wed Nov 14 2018 13:29:38 GMT+0800 (China Standard Time)

I made some revisions to no avail. The PR isn't as simple as we thought it might because it requires us to use SourceMapSource instead of OriginalSource which need us to have an inputSourceMap defined. Adding the line where asset.sourceAndMap will be defined would lead to a Javascript heap out of memory error. I don't know if I'm doing it right since I did not author this module..

Simon Phillip Guillen · Answer 6 · Wed Nov 14 2018 13:30:11 GMT+0800 (China Standard Time)

Reference to the changes I've applied are on this link.

Adam Stankiewicz · Answer 7 · Wed Nov 14 2018 20:50:24 GMT+0800 (China Standard Time)

@sprguillen I've published 2.0.0-alpha.0 which should have sourcemaps support. Do you want to test it?

Simon Phillip Guillen · Answer 8 · Wed Nov 14 2018 22:28:15 GMT+0800 (China Standard Time)

Great! Thanks, I'll gladly test it for you.

Simon Phillip Guillen · Answer 9 · Thu Nov 15 2018 13:16:24 GMT+0800 (China Standard Time)

I got this error, it's quite similar after I tried to applied the fix you mentioned..

Adam Stankiewicz · Answer 10 · Thu Nov 15 2018 15:12:40 GMT+0800 (China Standard Time)

Strange, webpack-source is in package.json so it should be installed. Maybe try to reinstall everything. I've just published 2.0.0-alpha.1 maybe it's better. If not maybe you could experiment in code I've pushed to master and send fixing PR?

…

On Thu, Nov 15, 2018 at 6:16 AM Simon Phillip Guillen < ***@***.***> wrote: [image: 2018-11-15_1314] <https://user-images.githubusercontent.com/1183103/48531770-8f539680-e8d8-11e8-944b-9bca2ea8c2c4.png> I got this error, it's quite similar after I tried to applied the fix you mentioned.. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAR2Dc0Wr8EPZJwo1cIPAkojslkeWHZXks5uvPiogaJpZM4Ya1NX> .

Simon Phillip Guillen · Answer 11 · Thu Nov 15 2018 16:38:55 GMT+0800 (China Standard Time)

Sorry my fault on webpack-source. I wasnt using 2.0 alpha but the Javascript heap out of memory is now happening on 2.0.0 alpha...

Adam Stankiewicz · Answer 12 · Thu Nov 15 2018 17:41:11 GMT+0800 (China Standard Time)

Did you try 2.0.0-alpha.1 ?

Simon Phillip Guillen · Answer 13 · Thu Nov 15 2018 21:12:09 GMT+0800 (China Standard Time)

Yes, that's the one causing the error..

Adam Stankiewicz · Answer 14 · Thu Nov 15 2018 21:42:21 GMT+0800 (China Standard Time)

I think it's simply because sourcemaps are generated and you don't have enough memory. You can pass { sourceMaps: false } to disable generating sourcemaps but in general you should disable it for development

Adam Stankiewicz · Answer 15 · Thu Nov 15 2018 21:42:47 GMT+0800 (China Standard Time)

Does it fail on CI as well?

Simon Phillip Guillen · Answer 16 · Thu Nov 15 2018 21:55:57 GMT+0800 (China Standard Time)

I haven't tried on CI. We actually need sourcemaps more on development rather than in production. :) I think bundling for legacy browsers + sourcemaps overloads NodeJS.

Adam Stankiewicz · Answer 17 · Thu Nov 15 2018 22:15:46 GMT+0800 (China Standard Time)

FYI it works for me on my CI, and on my OSX but I have 16GB ram

Simon Phillip Guillen · Answer 18 · Thu Nov 15 2018 22:18:30 GMT+0800 (China Standard Time)

What's your current setup? I'm currently using Windows, Node 10.9.0..

I actually have 16gb ram as well.. CI means continuous integration right? I'm currently not using any CI tools. Just yarn or npm.

Adam Stankiewicz · Answer 19 · Thu Nov 15 2018 23:10:07 GMT+0800 (China Standard Time)

Yes it means something like travis that deploys the service

…

On Thu, Nov 15, 2018 at 3:18 PM Simon Phillip Guillen < ***@***.***> wrote: What's your current setup? I'm currently using Windows, Node 10.9.0.. I actually have 16gb ram as well.. CI means continuous integration right? I'm currently not using any CI tools. Just yarn or npm. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAR2DVpZ8hXRfLOoUssGtoK2sendtEseks5uvXe2gaJpZM4Ya1NX> .

Simon Phillip Guillen · Answer 20 · Thu Nov 15 2018 23:18:01 GMT+0800 (China Standard Time)

I think it does make the difference, I don't use any CI tool and maybe that's why I have those heap issues. This plugin when sourceMap enabled may only be compatible with having been deployed by Travis.. Have you tried it without using Travis? Just running the node server using yarn or npm? Does it work?

Adam Stankiewicz · Answer 21 · Thu Nov 15 2018 23:22:01 GMT+0800 (China Standard Time)

As I said it works both on my CI (I'm using server on scaleway), and on my OSX machine.

…

On Thu, Nov 15, 2018 at 4:18 PM Simon Phillip Guillen < ***@***.***> wrote: I think it does make the difference, I don't use any CI tool and maybe that's why I have those heap issues. This plugin when sourceMap enabled may only be compatible with having been deployed by Travis.. Have you tried it without using Travis? Just running the node server using yarn or npm? Does it work? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAR2De9ay8hHDsA3-KmkvPV9gM6wPADsks5uvYWpgaJpZM4Ya1NX> .

Simon Phillip Guillen · Answer 22 · Tue Nov 20 2018 07:55:53 GMT+0800 (China Standard Time)

We made some changes on the webpack configuration and tested on 2.0.0-alpha.1, it successfully worked! Good job! Closing this issue now..

Adam Stankiewicz · Answer 23 · Tue Nov 20 2018 08:01:28 GMT+0800 (China Standard Time)

Glad to hear :) Mind to tell what changes?

Simon Phillip Guillen · Answer 24 · Tue Nov 20 2018 11:54:34 GMT+0800 (China Standard Time)

We used the webpack-bundle-analyzer and restructured how plugins are being loaded by webpack, that may have reduced the amount of memory webpack is consuming when compiling code.